I don't hate the deals. I'd probably want something more in the Scandella trade. Even though Bjugstad has struggled this season, he still has another year term left. I'd ask for a late round pick, like a 4th, or maybe even someone like Girgensons, who could give the team a little more experienced depth (and size) over guys like Blandisi and Lafferty.

On the Hall trade, I don't think Hallander is a good enough prospect. I think you'd have to include one of Legare, Poulin, or Addison to make it work. I'd only be willing to give up the 1st if Hall signs. Galchenyuk, Legare, and a conditional 2021 2nd (which becomes a 2020 1st if Hall resigns). Hall is a big name, but, I'm not sure Shero is going to be able to get more than 3 assets back for him, with his UFA status and all signs pointing to him wanting out. Legare is the prize here, and the 1st if the Penguins can get Hall signed.

Hall isn't worth nearly all of that. Even if he resigns.
He's gonna be 29 years old. His prime is gone. He's gonna want an 8 year deal, making him 36 in the final year. No way in hell. With his injury history you might get 1/2 of that contract out of him before it's a total waste.
He's not the prize people try to make him out to be. He'll get a 1st, and a B prospect at best. No one is sacrificing more than that. And very few teams are going to commit on a long term deal knowing his age. If he was 26-27 it would be a different story. He's not. Those 2-3 extra years past prime are huge burdens on any team.